Skip to content

Conversation

@shihzy
Copy link
Contributor

@shihzy shihzy commented Nov 10, 2020

Proposed change(s)

Describe the changes made in this PR.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

MLA-1466 and MLA-1557

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

shihzy and others added 2 commits November 10, 2020 16:47
Co-authored-by: Ervin T. <ervin@unity3d.com>
@shihzy shihzy changed the base branch from master to release_10_branch November 12, 2020 17:20
@shihzy
Copy link
Contributor Author

shihzy commented Nov 12, 2020

@vincentpierre are you okay if I merge this into the release_10 branch? made @ervteng requested changes but not in master yet.

@vincentpierre
Copy link
Contributor

If you want these changes in release_10, I think it is fine. Do you want to modify the changelog or you don't think it is needed?

@shihzy
Copy link
Contributor Author

shihzy commented Nov 12, 2020

If you want these changes in release_10, I think it is fine. Do you want to modify the changelog or you don't think it is needed?

no, i dont think we need to modify change log. i will merge. thx!

@shihzy shihzy merged commit 6ff6575 into release_10_branch Nov 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the docs-unityjeffrey branch November 12, 2020 17:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants