Check int overflow/ nan action for torch and add tests #4646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Add the int overflow/ nan action checks for torch
Use int tensor for global_step for torch: the int32 overflow problem doesn't happen in torch since torch use float tensors by default. But there's a subtle bug in this: when setting the global step to a very large number and then call get_current_step() where the step count is converted to int, there's some numerical error and the result will not be as expected, i.e.
This could be a potential bug when trying to resume training from a large step in torch.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments