-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[bug-fix] Add clipping to PyTorch policy, fix initialization #4649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a708af6.
ervteng
commented
Nov 13, 2020
5 tasks
vincentpierre
approved these changes
Nov 16, 2020
Contributor
vincentpierre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to cherry pick to release_10_branch after merge.
ervteng
pushed a commit
that referenced
this pull request
Nov 17, 2020
10 tasks
ervteng
pushed a commit
that referenced
this pull request
Nov 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
This PR is motivated by the perpetually lower resulting rewards that Torch PPO gets on ragdoll environments, especially Walker. It addresses two differences between Torch and TF PPO:
sqrt(2). This PR changes the nonlinearity assumed in the initializer tolinear, removing that extra factor ofsqrt(2). This initialization was the main cause of wildly higher value losses in Torch.tanhsquashing on Gaussian outputs (PPO), we truncate the output byclip(action, -3, 3) / 3. This PR adds the same thing to Torch.Types of change(s)
Checklist
Other comments