[bug-fix] Fix issue where NaNs are outputted by the policy when training Match3 #4664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
approved these changes
Nov 18, 2020
vincentpierre
approved these changes
Nov 18, 2020
chriselion
reviewed
Nov 18, 2020
| normalized_probs = raw_probs / torch.sum(raw_probs, dim=-1).unsqueeze(-1) | ||
| normalized_logits = torch.log(normalized_probs + EPSILON) | ||
| return normalized_logits | ||
| # Zero out masked logits, then subtract a large value |
Contributor
There was a problem hiding this comment.
Can you link to the paper/blog post that this was adapted from?
added 2 commits
November 18, 2020 11:49
ervteng
pushed a commit
that referenced
this pull request
Nov 18, 2020
…ing Match3 (#4664) * match3 settings * Add epsilon to log * Add another epsilon * Revert match3 configs * NaN-free masking method * Add comment for paper * Add comment for paper Co-authored-by: Chris Elion <chris.elion@unity3d.com>
ervteng
pushed a commit
that referenced
this pull request
Nov 18, 2020
* match3 settings * Add epsilon to log * Add another epsilon * Revert match3 configs * NaN-free masking method * Add comment for paper * Add comment for paper Co-authored-by: Chris Elion <chris.elion@unity3d.com> Co-authored-by: Chris Elion <chris.elion@unity3d.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
In certain environments (particularly with large action spaces), discrete actions can become
NaNoccasionally. This is especially evident with the Match3 environment.This PR adds a small epsilon value to any division or log function that may converge very close to zero, particularly in the
MultiCategoricalDistributionandCategoricalDistInstance.Types of change(s)
Checklist
Other comments