Skip to content

Cherrypick onnx export threading fix to release 10 #4665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Cherrypick onnx export threading fix to release 10 #4665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ml-agents/mlagents/trainers/torch/model_serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,20 @@ class exporting_to_onnx:
This implementation is thread safe.
"""

# local is_exporting flag for each thread
_local_data = threading.local()
_local_data._is_exporting = False

# global lock shared among all threads, to make sure only one thread is exporting at a time
_lock = threading.Lock()

def __enter__(self):
self._lock.acquire()
self._local_data._is_exporting = True

def __exit__(self, *args):
self._local_data._is_exporting = False
self._lock.release()

@staticmethod
def is_exporting():
Expand Down