Skip to content

Cherry-pick separate critic only for PPO (#4661) to Release 10 #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

Cherry-pick separate critic only for PPO (#4661) to Release 10 #4666

merged 1 commit into from
Nov 18, 2020

Conversation

@ervteng
Copy link
Contributor

@ervteng ervteng commented Nov 18, 2020

Proposed change(s)

Cherry pick #4661 to Release 10

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng merged commit b0ac32e into release_10_branch Nov 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the release-cherrypick-sepcritic branch November 18, 2020 19:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vincentpierre vincentpierre vincentpierre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ervteng @vincentpierre