Uncomment obsolete attributes, fix warnings #4771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewcoh
reviewed
Dec 17, 2020
andrewcoh
reviewed
Dec 17, 2020
andrewcoh
reviewed
Dec 17, 2020
andrewcoh
reviewed
Dec 17, 2020
andrewcoh
approved these changes
Dec 17, 2020
dongruoping
approved these changes
Dec 17, 2020
chriselion
commented
Dec 17, 2020
chriselion
commented
Dec 17, 2020
chriselion
commented
Dec 17, 2020
chriselion
commented
Dec 17, 2020
chriselion
commented
Dec 17, 2020
chriselion
commented
Dec 17, 2020
chriselion
commented
Dec 17, 2020
Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com>
chriselion
pushed a commit
that referenced
this pull request
Dec 17, 2020
* uncomment obsolete attributes, fix warnings * Apply suggestions from code review Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com> Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com>
chriselion
pushed a commit
that referenced
this pull request
Dec 18, 2020
* uncomment obsolete attributes, fix warnings * Apply suggestions from code review Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com> Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com> Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Several fields have [Obsolete] commented out, which doesn't do anything. This comments them back in, and fixes any places where we were using them (fortunately just places where we explicitly were going for backwards compatibility).
Might need to update the migration guide.
Will cherrypick to release branch.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://jira.unity3d.com/browse/MLA-1604
Types of change(s)
Checklist
Other comments