Skip to content

remove spec property in gym wrapper #4985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2021
Merged

remove spec property in gym wrapper #4985

merged 1 commit into from
Feb 22, 2021

Conversation

@andrewcoh
Copy link
Contributor

Proposed change(s)

#4963

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

vincentpierre
vincentpierre approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@vincentpierre vincentpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the original issue so the user can keep track.

@andrewcoh andrewcoh merged commit d2c5697 into master Feb 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove-spec-gym branch February 22, 2021 21:07
philippds added a commit to philippds-forks/ml-agents that referenced this pull request Feb 22, 2021
@philippds
Merge pull request #2 from Unity-Technologies/master
8bc1718 
remove spec property in gym wrapper (Unity-Technologies#4985)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vincentpierre vincentpierre vincentpierre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewcoh @vincentpierre