Add rendering to Gym wrapper limitations #5389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gym-unity/README.md
Outdated
| be accessed from the `info` provided by `env.step(action)`. | ||
| - Stacked vector observations are not supported. | ||
| - Environment registration for use with `gym.make()` is currently not supported. | ||
| - Display rendering is not supported. Calling `env.render()` might not work as expected in display. |
Contributor
There was a problem hiding this comment.
It is not true that it is not supported in my opinion. I think we could :
- remove the
env.render()method and then just say "Display rendering is not supported." - keep
env.renderas is and say here : "Callingenv.render()will return the latest visual observation. It will not render a new frame of the environment." (also change the docstring on the method.) - implement a proper
env.render(). This is a lot of work for not a lot of benefit IMO.
Contributor
Author
There was a problem hiding this comment.
For simplicity I prefer not to change/remove the interface now. So I went with second option and updated the doc, let me know what you think.
Co-authored-by: Vincent-Pierre BERGES <vincentpierre@unity3d.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Reported in #5380 . We didn't mention the limitation around rendering in the documents and it's not working as expected for users.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments