Skip to content

Fix quicklook animation export #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcowles merged 3 commits into from
May 7, 2020
Merged

Fix quicklook animation export #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd2be22
time-to-frames conversion to prevent QuickLook bugs
hybridherbst Apr 24, 2020
aa5e91b
added sample data
hybridherbst Apr 24, 2020
766cbf8
requested changes
hybridherbst Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions package/com.unity.formats.usd/Runtime/Scripts/Timeline/UsdRecorderBehaviour.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
namespace Unity.Formats.USD {
public class UsdRecorderBehaviour : PlayableBehaviour {

// Conversion to keyframes (60 frames per second) to work around QuickLook bug
const int kExportFrameRate = 60;
bool m_isPaused = false;
public UsdRecorderClip Clip;

Expand Down Expand Up @@ -67,9 +69,13 @@ public void BeginRecording(double currentTime, GameObject root) {
// m_usdScene.Stage.SetTimeCodesPerSecond(1);
//}

// TODO: How does one extract the time mode (frames or seconds) from the Timeline?
Clip.UsdScene.Stage.SetFramesPerSecond(30);
Clip.UsdScene.Stage.SetTimeCodesPerSecond(1);
// Regardless of the actual sampling rate (e.g. Timeline playback speed), we are converting
// the timecode from seconds to frames with a sampling rate of 60 FPS. This has the nice quality
// of adding additional numerical stability.
// In the event that the timeline is not configured for 60 FPS playback, we rely on USD's linear
// interpolation mode to up-sample to 60 FPS.
Clip.UsdScene.FrameRate = kExportFrameRate ;
Clip.UsdScene.Stage.SetInterpolationType(pxr.UsdInterpolationType.UsdInterpolationTypeLinear);

// For simplicity in this example, adding game objects while recording is not supported.
Clip.Context = new ExportContext();
Expand All @@ -78,7 +84,7 @@ public void BeginRecording(double currentTime, GameObject root) {
Clip.Context.activePolicy = Clip.m_activePolicy;
Clip.Context.exportMaterials = Clip.m_exportMaterials;

Clip.UsdScene.StartTime = currentTime;
Clip.UsdScene.StartTime = currentTime * kExportFrameRate ;

// Export the "default" frame, that is, all data which doesn't vary over time.
Clip.UsdScene.Time = null;
Expand All @@ -104,7 +110,7 @@ public void StopRecording(double currentTime) {
}

Clip.Context = new ExportContext();
Clip.UsdScene.EndTime = currentTime;
Clip.UsdScene.EndTime = currentTime * kExportFrameRate ;

// In a real exporter, additional error handling should be added here.
if (!string.IsNullOrEmpty(Clip.m_usdFile)) {
Expand All @@ -129,7 +135,7 @@ void ProcessRecording(double currentTime, GameObject root) {
Debug.LogError("Process: context.scene is null");
}

Clip.UsdScene.Time = currentTime;
Clip.UsdScene.Time = currentTime * kExportFrameRate ;
Clip.Context.exportMaterials = false;
SceneExporter.Export(root, Clip.Context, zeroRootTransform: false);
}
Expand Down Expand Up @@ -195,4 +201,4 @@ public void OnFrameEnd(Playable playable, FrameData info, object playerData) {
ProcessRecording(playable.GetTime(), Clip.GetExportRoot(playable.GetGraph()));
}
}
}
}
Loading