Fix build regressions (#USDU-165) #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one flag the assembly to be ignored in builds
plugInfo.json was removed from the x86_64 causing USD failure at runtime.
phocodes
approved these changes
May 27, 2021
judubu
force-pushed
the
USDU-165/fix_il2cpp_builds
branch
from
2ee9dc8 to
8dfe7d8
Compare
clusty
reviewed
May 31, 2021
clusty
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ticket/Jira #: https://jira.unity3d.com/browse/USDU-165
This fixes a couple of different regression introduces recently:
From now on playmode tests will run in standalone and target both il2cpp and mono to catch similar issues
Testing
Functional Testing status:
Manually build the test project for mono and il2cpp
Performance Testing status:
N/A
Overall Product Risks
Complexity:
Minimal
Halo Effect:
Minimal
Additional information
Note to reviewers:
Reminder: