remove extra values from shib attributes #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonLeary42
force-pushed
the
shib-dupe-attributes
branch
4 times, most recently
from
cc9922e to
0c79c9a
Compare
simonLeary42
force-pushed
the
shib-dupe-attributes
branch
from
0c79c9a to
b35bfa8
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new helper method to properly handle Shibboleth attribute values that may contain multiple semicolon-delimited values, ensuring only the first value is used.
- Adds a
getAttribute()method to extract and clean Shibboleth attributes - Updates the
getSSO()method to use the new helper instead of direct$_SERVERaccess - Implements fallback support for the mail attribute using "eppn" as backup
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
Author
|
switched back to draft, I want |
simonLeary42
force-pushed
the
shib-dupe-attributes
branch
from
5f7ceab to
21f49e1
Compare
bryank-cs
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.