Skip to content

Conversation

@simonLeary42
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the userExists method to memberExists in the UnityGroup class to better reflect its purpose of checking group membership. The change improves the semantic clarity of the API by using more descriptive naming.

  • Renamed UnityGroup::userExists() method to UnityGroup::memberExists()
  • Updated all method calls across the codebase to use the new method name
  • Updated test assertions to use the renamed method

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
resources/lib/UnityGroup.php Renamed method definition from userExists to memberExists
workers/remove-users-from-group.php Updated method call to use new name
webroot/panel/groups.php Updated method call to use new name
webroot/panel/ajax/get_group_members.php Updated method call to use new name
test/functional/PiRemoveUserTest.php Updated test assertions to use new method name
test/functional/PiMemberDenyTest.php Updated test assertions to use new method name
test/functional/PiMemberApproveTest.php Updated test assertions to use new method name
test/functional/PIMemberRequestTest.php Updated test assertions to use new method name
test/functional/NewUserTest.php Updated test assertions to use new method name

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@simonLeary42 simonLeary42 merged commit e3c08b0 into main Sep 26, 2025
2 checks passed
@simonLeary42 simonLeary42 deleted the rename-func branch September 26, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants