Skip to content

Conversation

@ayushmansatpathy
Copy link
Collaborator

@ayushmansatpathy ayushmansatpathy commented Oct 17, 2025

PHPStan (the new static analysis tool) raised errors in incorrect variable case, unused functions, and incorrect number of parameters. This was manually fixed to ensure that PHPStan did not raise any other errors when it analysed the resources folder.

Additionally, this commit includes the installation of psalm.dev, another static analysis tool.

@simonLeary42 simonLeary42 requested a review from Copilot October 17, 2025 17:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR resolves static analysis errors identified by PHPStan and adds Psalm as an additional static analysis tool. The changes fix incorrect class name casing, correct a method name call, and add both PHPStan and Psalm to the project's development dependencies.

  • Fixed class name casing from unityLDAP to UnityLDAP in multiple method calls
  • Corrected method call from getGroupMemberUIDs() to getOrgMemberUIDs()
  • Added PHPStan and Psalm static analysis tools to composer.json
  • Fixed docker exec command parameter order in documentation

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
resources/lib/phpopenldaper Updated subproject commit reference
resources/lib/UnityOrg.php Corrected method name from getGroupMemberUIDs to getOrgMemberUIDs
resources/lib/UnityLDAP.php Fixed class name casing from unityLDAP to UnityLDAP in four method calls
psalm.xml Added Psalm configuration file for static analysis
composer.json Added PHPStan and Psalm as development dependencies
CONTRIBUTING.md Fixed docker exec command parameter order

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@simonLeary42
Copy link
Collaborator

TODO if these function calls have been wrong, we need to make regression tests that demonstrate the wrongness

@simonLeary42
Copy link
Collaborator

TODO open PR to hakasapl/phpopenldaper, merge, then update submodule commit here to point to main branch

@simonLeary42
Copy link
Collaborator

#339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants