Resolved errors raised by PHPStan

CONTRIBUTING.md

@@ -82,7 +82,7 @@ cd ./tools/docker-dev
 tab 2:
 ```
 $ container="$(docker container ls | grep web | awk '{print $1}')"
-$ docker exec "$container" -it bash
+$ docker exec -it "$container" bash
 > cd /var/www/unity-web
 > ./vendor/bin/phpunit /path/to/tests
 ```

composer.json

@@ -6,6 +6,8 @@
     },
     "require-dev": {
         "phpunit/phpunit": "<12.1",
-        "robiningelbrecht/phpunit-coverage-tools": "<2"
+        "robiningelbrecht/phpunit-coverage-tools": "<2",
+        "phpstan/phpstan": "^2.1",
+        "vimeo/psalm": "^6.13"
     }
 }

psalm.xml

@@ -0,0 +1,21 @@
+<?xml version="1.0"?>
+<psalm
+    errorLevel="4"
+    resolveFromConfigFile="true"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns="https://getpsalm.org/schema/config"
+    xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
+    findUnusedBaselineEntry="true"
+    findUnusedCode="true"
+>
+    <projectFiles>
+        <file name="coverage.php" />
+        <directory name="test" />
+        <directory name="resources" />
+        <directory name="webroot" />
+        <directory name="workers" />
+        <ignoreFiles>
+            <directory name="vendor" />
+        </ignoreFiles>
+    </projectFiles>
+</psalm>

resources/lib/UnityLDAP.php

@@ -419,24 +419,24 @@ public function getAllOrgGroupsAttributes($attributes)
     public function getUserEntry($uid)
     {
         $uid = ldap_escape($uid, "", LDAP_ESCAPE_DN);
-        return $this->getEntry(unityLDAP::RDN . "=$uid," . CONFIG["ldap"]["user_ou"]);
+        return $this->getEntry(UnityLDAP::RDN . "=$uid," . CONFIG["ldap"]["user_ou"]);
     }
 
     public function getGroupEntry($gid)
     {
         $gid = ldap_escape($gid, "", LDAP_ESCAPE_DN);
-        return $this->getEntry(unityLDAP::RDN . "=$gid," . CONFIG["ldap"]["group_ou"]);
+        return $this->getEntry(UnityLDAP::RDN . "=$gid," . CONFIG["ldap"]["group_ou"]);
     }
 
     public function getPIGroupEntry($gid)
     {
         $gid = ldap_escape($gid, "", LDAP_ESCAPE_DN);
-        return $this->getEntry(unityLDAP::RDN . "=$gid," . CONFIG["ldap"]["pigroup_ou"]);
+        return $this->getEntry(UnityLDAP::RDN . "=$gid," . CONFIG["ldap"]["pigroup_ou"]);
     }
 
     public function getOrgGroupEntry($gid)
     {
         $gid = ldap_escape($gid, "", LDAP_ESCAPE_DN);
-        return $this->getEntry(unityLDAP::RDN . "=$gid," . CONFIG["ldap"]["orggroup_ou"]);
+        return $this->getEntry(UnityLDAP::RDN . "=$gid," . CONFIG["ldap"]["orggroup_ou"]);
     }
 }

resources/lib/UnityOrg.php

@@ -50,7 +50,7 @@ public function inOrg($user, $ignorecache = false)
 
     public function getOrgMembers($ignorecache = false)
     {
-        $members = $this->getGroupMemberUIDs($ignorecache);
+        $members = $this->getOrgMemberUIDs($ignorecache);
         $out = array();
         foreach ($members as $member) {
             $user_obj = new UnityUser(