Skip to content

add users to LDAP immediately #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonLeary42 merged 2 commits into from
Nov 17, 2025
Merged

add users to LDAP immediately #349

simonLeary42 merged 2 commits into from
Nov 17, 2025

Conversation

@simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Nov 10, 2025 •
edited
Loading

Closes #302

Partially reverts #244

@simonLeary42 simonLeary42 changed the title remove data from request table add users to LDAP immediately Nov 10, 2025
@simonLeary42 simonLeary42 force-pushed the allow-registration-without-group branch from 46f41ae to 45bab8c Compare November 10, 2025 20:22
simonLeary42
simonLeary42 commented Nov 10, 2025
View reviewed changes
README.md

- the `[ldap]user_group` option has been renamed to `[ldap]qualified_user_group`
- the `user_created ` mail template has been renamed to `user_qualified`
- the `user_dequalified` mail template has been added
Copy link
Collaborator Author

@simonLeary42 simonLeary42 Nov 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • TODO this isn't used, use it or document it

@simonLeary42
Copy link
Collaborator Author

simonLeary42 commented Nov 12, 2025 •
edited
Loading

  • TODO update unity-course.php, which uses UnityGroup->newUserRequest

@simonLeary42 simonLeary42 force-pushed the allow-registration-without-group branch 3 times, most recently from 352ecc3 to 62c083c Compare November 13, 2025 19:18
@simonLeary42 simonLeary42 force-pushed the allow-registration-without-group branch 3 times, most recently from 6da7fb5 to 1c41934 Compare November 13, 2025 20:57
@simonLeary42
Copy link
Collaborator Author

simonLeary42 commented Nov 13, 2025 •
edited
Loading

  • TODO elements missing from account.php

@simonLeary42
Copy link
Collaborator Author

simonLeary42 commented Nov 13, 2025 •
edited
Loading

  • TODO database migration: create entries for all users with requests, delete columns from request table

@simonLeary42 simonLeary42 force-pushed the allow-registration-without-group branch 14 times, most recently from 2259c78 to 57220b2 Compare November 17, 2025 17:10
@simonLeary42 simonLeary42 force-pushed the allow-registration-without-group branch from 57220b2 to 40ea9cf Compare November 17, 2025 17:12
@simonLeary42 simonLeary42 marked this pull request as ready for review November 17, 2025 17:19
@simonLeary42 simonLeary42 merged commit 86ca88e into main Nov 17, 2025
2 of 3 checks passed
@simonLeary42 simonLeary42 deleted the allow-registration-without-group branch November 17, 2025 17:19
This was referenced Nov 19, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add users to LDAP immediately

2 participants

@simonLeary42