Skip to content

remove redis flush from tests #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonLeary42 merged 1 commit into from
Nov 26, 2025
Merged

remove redis flush from tests #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/functional/PIBecomeApproveTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ public function testApprovePI()
$this->requestGroupCreation();
$this->assertRequestedPIGroup(true);

$REDIS->flushAll(); // regression test: flush used to break requests

$approve_uid = $SSO["user"];
switchUser(...getAdminUser());
$this->approveGroup($approve_uid);
Expand Down
4 changes: 0 additions & 4 deletions test/functional/PiMemberApproveTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,6 @@ public function testApproveMemberByPI()
$this->assertTrue($pi_group->requestExists($USER));
$this->assertRequestedMembership(true, $gid);

$REDIS->flushAll(); // regression test: flush used to break requests

$approve_uid = $SSO["user"];
switchUser(...$pi_user_args);
$this->approveUserByPI($approve_uid);
Expand Down Expand Up @@ -176,8 +174,6 @@ public function testApproveMemberByAdmin()
$this->assertTrue($pi_group->requestExists($USER));
$this->assertRequestedMembership(true, $gid);

$REDIS->flushAll(); // regression test: flush used to break requests

$approve_uid = $SSO["user"];
switchUser(...getAdminUser());
$this->approveUserByAdmin($gid, $approve_uid);
Expand Down