-
Notifications
You must be signed in to change notification settings - Fork 11
remove redis #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove redis #368
Conversation
|
TODO nevermind, nonexistent attributes already return empty array |
09a14b9 to
0a8f5da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes Redis caching functionality from the Unity Web Portal codebase in response to issue #289. The change simplifies the architecture by eliminating the Redis dependency and its associated caching layer, relying instead on direct LDAP queries.
Key changes:
- Removed the entire
UnityRedisclass and all Redis-related infrastructure - Updated all class constructors (
UnityUser,UnityGroup,UnityOrg) to remove Redis parameters - Eliminated the
$ignorecacheparameter from getter methods throughout the codebase
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workers/update-ldap-cache.php | Deleted worker script that populated Redis cache from LDAP |
| workers/remove-users-from-group.php | Removed Redis parameter from UnityGroup and UnityUser instantiation |
| workers/group_user_request_owner_reminder.php | Removed Redis parameter from getAllPIGroups call |
| webroot/panel/pi.php | Removed Redis parameter from UnityUser instantiation |
| webroot/panel/new_account.php | Removed Redis parameter from UnityUser instantiation |
| webroot/panel/modal/pi_search.php | Removed Redis parameter from getAllPIGroups call |
| webroot/panel/groups.php | Removed Redis parameters from UnityGroup instantiations |
| webroot/panel/ajax/get_group_members.php | Removed Redis parameter from UnityGroup instantiation |
| webroot/admin/pi-mgmt.php | Removed Redis parameters from UnityUser and UnityGroup instantiations |
| webroot/admin/ajax/get_group_members.php | Removed Redis parameter from UnityGroup instantiation |
| tools/docker-dev/web/Dockerfile | Removed php-redis extension and simplified startup command |
| tools/docker-dev/redis/Dockerfile | Deleted Redis Docker container configuration |
| tools/docker-dev/docker-compose.yml | Removed Redis service and dependency references |
| test/phpunit-bootstrap.php | Removed Redis global variable and cache cleanup logic from test utilities |
| test/functional/RegisterUserTest.php | Removed Redis from global variables |
| test/functional/PiRemoveUserTest.php | Removed Redis parameters from UnityUser instantiations |
| test/functional/PiMemberDenyTest.php | Removed Redis parameter from UnityUser instantiation |
| test/functional/PiMemberApproveTest.php | Removed Redis from global variables |
| test/functional/PageLoadTest.php | Removed Redis from global variables |
| test/functional/PIBecomeApproveTest.php | Removed Redis from global variables |
| resources/lib/UnityUser.php | Removed Redis dependency, caching logic, and $ignorecache parameters from all getter methods |
| resources/lib/UnityRedis.php | Deleted entire Redis wrapper class |
| resources/lib/UnityOrg.php | Removed Redis dependency and caching logic from organization group operations |
| resources/lib/UnityLDAP.php | Removed Redis parameters and caching logic from user/group retrieval methods |
| resources/lib/UnityGroup.php | Removed Redis dependency and caching logic from PI group operations |
| resources/init.php | Removed Redis initialization and cache population logic |
| resources/autoload.php | Removed UnityRedis require statement |
| defaults/config.ini.default | Removed Redis configuration section |
| README.md | Removed redis from PHP extension requirements and updated example code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
#289