optimize fetching of group member attributes #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the performance of fetching group member attributes by introducing a new method that retrieves only the necessary LDAP attributes (gecos, mail) in a single batch query, rather than creating individual UnityUser objects for each member.
Key changes:
- Introduced
getUsersAttributes()method in UnityLDAP to batch-fetch specific user attributes - Added
getGroupMembersAttributes()wrapper method in UnityGroup - Updated both panel and admin group member display pages to use the optimized approach
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| resources/lib/UnityLDAP.php | Added new getUsersAttributes() method to batch-fetch user LDAP attributes with filtering |
| resources/lib/UnityGroup.php | Added getGroupMembersAttributes() wrapper to fetch member attributes via LDAP |
| webroot/panel/ajax/get_group_members.php | Refactored to use optimized attribute fetching instead of full UnityUser objects |
| webroot/admin/ajax/get_group_members.php | Refactored to use optimized attribute fetching instead of full UnityUser objects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#346