[APIN-1739]Remove omitempty from connectiontype#10
Merged
minhao merged 2 commits intoUnityTech:masterfrom Jun 14, 2019
Merged
Conversation
added 2 commits
June 13, 2019 17:17
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The implementation for 'connectiontype' guarantees the field should be always in the bid request.
But there are cases the field is missing.
https://console.cloud.google.com/logs/viewer?interval=NO_LIMIT&project=unity-ads-exchg-gke-prd&authuser=0&organizationId=1050374768111&orgonly=true&minLogLevel=0&expandAll=false×tamp=2019-06-13T07:52:47.616000000Z&customFacets=&limitCustomFacetWidth=true&scrollTimestamp=2019-06-13T10:17:35.000000000Z&advancedFilter=resource.type%3D%22container%22%0Aresource.labels.cluster_name%3D%22unity-ads-exchg-auction-gke-prd-usc1%22%0Aresource.labels.namespace_id%3D%22ads%22%0Aresource.labels.project_id%3D%22unity-ads-exchg-gke-prd%22%0Aresource.labels.zone:%22us-central1-%22%0Aresource.labels.container_name%3D(%22init-vault-secret-fetcher%22%20OR%20%22ads-brand%22)%0Aresource.labels.pod_id:%22ads-brand-%22%0AjsonPayload.message:%22Payload%22%0ANOT%20jsonPayload.message:%22user_agent%22%0ANOT%20jsonPayload.message:%22connectiontype%22%0A
WHY
omitempty will drop the field when it is an empty value.
But for 'connectiontype' field, 0 is a valid type in openrtb spec and should be parsed to our DSPs.
HOW
remove omitempty from connectiontype
JIRA
https://jira.hq.unity3d.com/browse/APIN-1739