Fix links not working inside of link box and implement Echo and VisualEditor support. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the way echo support is implemented is not so great. but to implement ve support i just had to rename `#article` to `#content`.
forkiesassds
changed the title
Owner
|
Thank you! I will test and hopefully merge this later. |
Universal-Omega
added a commit
that referenced
this pull request
Jun 22, 2021
* $revision->getText() does not exist (#6) * Fix links not working inside of link box and implement Echo and VisualEditor support. (#7) * echo and ve support the way echo support is implemented is not so great. but to implement ve support i just had to rename `#article` to `#content`. * fix links inside link box not working * skin.json already loads most of the resources, well except for ie specific ones. * +newline * Formatting Co-authored-by: Universal Omega <54654040+Universal-Omega@users.noreply.github.com> Co-authored-by: forkiesassds <54495659+forkiesassds@users.noreply.github.com>
Universal-Omega
added a commit
that referenced
this pull request
Dec 18, 2021
* Cleanup * Merge branch 'master' into Universal-Omega-patch-1 (#8) * $revision->getText() does not exist (#6) * Fix links not working inside of link box and implement Echo and VisualEditor support. (#7) * echo and ve support the way echo support is implemented is not so great. but to implement ve support i just had to rename `#article` to `#content`. * fix links inside link box not working * skin.json already loads most of the resources, well except for ie specific ones. * +newline * Formatting Co-authored-by: Universal Omega <54654040+Universal-Omega@users.noreply.github.com> Co-authored-by: forkiesassds <54495659+forkiesassds@users.noreply.github.com> Co-authored-by: forkiesassds <54495659+forkiesassds@users.noreply.github.com>
paladox
added a commit
to paladox/Monaco
that referenced
this pull request
Jan 28, 2025
…dVariant()" ``` from /srv/mediawiki/1.43/skins/Monaco/includes/MonacoTemplate.php(1104) #0 /srv/mediawiki/1.43/skins/Monaco/includes/MonacoTemplate.php(1080): MonacoTemplate->realPrintPageBar() Universal-Omega#1 /srv/mediawiki/1.43/skins/Monaco/includes/MonacoTemplate.php(115): MonacoTemplate->printPageBar() Universal-Omega#2 /srv/mediawiki/1.43/includes/skins/SkinTemplate.php(161): MonacoTemplate->execute() Universal-Omega#3 /srv/mediawiki/1.43/includes/skins/SkinTemplate.php(180): SkinTemplate->generateHTML() Universal-Omega#4 /srv/mediawiki/1.43/includes/skins/Skin.php(683): SkinTemplate->outputPage() Universal-Omega#5 /srv/mediawiki/1.43/includes/Output/OutputPage.php(3193): Skin->outputPageFinal(MediaWiki\Output\OutputPage) Universal-Omega#6 /srv/mediawiki/1.43/includes/actions/ActionEntryPoint.php(163): MediaWiki\Output\OutputPage->output(bool) Universal-Omega#7 /srv/mediawiki/1.43/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute() Universal-Omega#8 /srv/mediawiki/config/initialise/entrypoints/index.php(98): MediaWiki\MediaWikiEntryPoint->run() Universal-Omega#9 {main} ```
Universal-Omega
pushed a commit
that referenced
this pull request
Jan 28, 2025
…dVariant()" (#35) ``` from /srv/mediawiki/1.43/skins/Monaco/includes/MonacoTemplate.php(1104) #0 /srv/mediawiki/1.43/skins/Monaco/includes/MonacoTemplate.php(1080): MonacoTemplate->realPrintPageBar() #1 /srv/mediawiki/1.43/skins/Monaco/includes/MonacoTemplate.php(115): MonacoTemplate->printPageBar() #2 /srv/mediawiki/1.43/includes/skins/SkinTemplate.php(161): MonacoTemplate->execute() #3 /srv/mediawiki/1.43/includes/skins/SkinTemplate.php(180): SkinTemplate->generateHTML() #4 /srv/mediawiki/1.43/includes/skins/Skin.php(683): SkinTemplate->outputPage() #5 /srv/mediawiki/1.43/includes/Output/OutputPage.php(3193): Skin->outputPageFinal(MediaWiki\Output\OutputPage) #6 /srv/mediawiki/1.43/includes/actions/ActionEntryPoint.php(163): MediaWiki\Output\OutputPage->output(bool) #7 /srv/mediawiki/1.43/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute() #8 /srv/mediawiki/config/initialise/entrypoints/index.php(98): MediaWiki\MediaWikiEntryPoint->run() #9 {main} ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes links not working inside of the link box and additionally adds support for Echo and VisualEditor
The way Echo support is implemented is not so great. But to implement VisualEditor support I just had to rename
#articleto#content.