Conversation
… help() command), plus misc pep8 fixes
|
When will someone run a Polyglot nodeserver from the shell? |
Collaborator
Author
|
Most likely never, which is why it doesn't make sense to initialize logging / intercepts when loaded from it. This is the point of the change. If you meant to ask why use this module in interactive shell to start with, the answer is - it's usually much easier to start/test initial development and the fastest way to get documentation without having to lookup project on github and diving into code or looking for other documentation. |
exking
approved these changes
Apr 28, 2018
Contributor
exking
left a comment
There was a problem hiding this comment.
Looks good to me, definitely would make PyCharm happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stdin/err intercepts should not be initialized when loading interactive shell. Otherwise, you cannot load module and issue help command, or just about do anything else in the shell, since output is intercepted.
I'd go a step further and never do it implicitly, instead doing it in Controller class but that might cause some incompatibility.
Rest of the changes are pep8 related minor fixes. They didn't break anything but created lots of linter noise.