Fix filesystem linking on GCC 8 and add RHEL CI workflow#454
Merged
urfeex merged 2 commits intoUniversalRobots:masterfrom Mar 4, 2026
Merged
Fix filesystem linking on GCC 8 and add RHEL CI workflow#454urfeex merged 2 commits intoUniversalRobots:masterfrom
urfeex merged 2 commits intoUniversalRobots:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
==========================================
- Coverage 76.28% 76.26% -0.03%
==========================================
Files 105 105
Lines 5537 5535 -2
Branches 593 593
==========================================
- Hits 4224 4221 -3
- Misses 1015 1016 +1
Partials 298 298
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses issue https://github.com.mcas.ms/UniversalRobots/Universal_Robots_Client_Library/issues/448 where linking fails when building URCL with GCC 8 on RHEL8 environments.
The error originates from unresolved std::filesystem symbols:
../liburcl.so: undefined reference to std::filesystem::__cxx11::path::parent_path() const../liburcl.so: undefined reference to std::filesystem::__cxx11::path::has_root_directory() const../liburcl.so: undefined reference to std::filesystem::__cxx11::path::_M_split_cmpts()../liburcl.so: undefined reference to std::filesystem::__cxx11::path::has_filename() constcollect2: error: ld returned 1 exit statusRoot Cause
On GCC 8, the
<filesystem>implementation is not included in the standard library by default.It must be explicitly linked via:
target_link_libraries(urcl PUBLIC stdc++fs)Newer GCC versions perform this automatically, which is why the issue only appears on RHEL 8 buildfarm jobs.
Fix
This PR adds the explicit link dependency for
stdc++fsin the CMake to ensure the linking for GCC8Additional Improvements: RHEL CI Workflow
To prevent regressions and ensure URCL builds correctly on all supported RHEL toolchains, this PR introduces a new GitHub Actions workflow:
The workflow performs a minimal workspace build using colcon inside the container, matching the RHEL buildfarm configuration.
Local Validation
The new workflow has been tested locally using https://github.com/nektos/act and all matrix jobs completed successfully.