Skip to content

Make circular motion in example more compatible#508

Merged
urfeex merged 1 commit into
UniversalRobots:masterfrom
urfeex:fix_cb3_example
May 19, 2026
Merged

Make circular motion in example more compatible#508
urfeex merged 1 commit into
UniversalRobots:masterfrom
urfeex:fix_cb3_example

Conversation

@urfeex

@urfeex urfeex commented May 19, 2026

Copy link
Copy Markdown
Member

This motion should work on

  • UR5
  • UR5e
  • UR20

These are all the models we currently use during tests.

Another approach would be to use relative target positions, but I would like to leave that for a later iteration.


Note

Low Risk
Low risk: changes are limited to an example program’s hardcoded motion waypoints and should not affect library behavior. Main risk is the updated demo trajectory still failing or behaving unexpectedly on some robot configurations.

Overview
Adjusts the examples/instruction_executor.cpp motion demo to make the showcased circular move (moveC) more broadly executable across UR5/UR5e/UR20.

Specifically replaces the previous moveC via/target waypoints with a preceding moveP and new via/target pose + joint targets intended to be more compatible.

Reviewed by Cursor Bugbot for commit ee4bd1a. Bugbot is set up for automated code reviews on this repo. Configure here.

This motion should work on

- UR5
- UR5e
- UR20

These are all the models we currently use during tests.
@urfeex urfeex requested a review from a team May 19, 2026 07:57
@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.31%. Comparing base (3f95311) to head (ee4bd1a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
+ Coverage   76.96%   77.31%   +0.35%     
==========================================
  Files         116      116              
  Lines        6343     6353      +10     
  Branches     2761     2764       +3     
==========================================
+ Hits         4882     4912      +30     
+ Misses       1113     1087      -26     
- Partials      348      354       +6     
Flag Coverage Δ
check_version_ur10-3.15.8 11.98% <ø> (?)
check_version_ur10e-10.11.0 11.73% <ø> (?)
check_version_ur10e-5.15.2 12.17% <ø> (?)
check_version_ur12e-10.12.1 11.73% <ø> (?)
check_version_ur12e-5.25.1 11.93% <ø> (?)
check_version_ur15-10.12.1 11.73% <ø> (?)
check_version_ur15-5.25.1 11.78% <ø> (?)
check_version_ur16e-10.12.1 11.73% <ø> (?)
check_version_ur16e-5.25.1 11.73% <ø> (?)
check_version_ur18-10.12.1 11.73% <ø> (?)
check_version_ur18-5.25.1 11.73% <ø> (?)
check_version_ur20-10.12.1 11.73% <ø> (?)
check_version_ur20-5.25.1 11.93% <ø> (?)
check_version_ur3-3.14.3 11.78% <ø> (?)
check_version_ur30-10.12.1 11.83% <ø> (?)
check_version_ur30-5.25.1 11.73% <ø> (?)
check_version_ur3e-10.11.0 11.73% <ø> (?)
check_version_ur3e-5.9.4 12.17% <ø> (?)
check_version_ur5-3.15.8 13.22% <ø> (?)
check_version_ur5e-10.11.0 11.73% <ø> (?)
check_version_ur5e-5.12.8 11.93% <ø> (?)
check_version_ur7e-10.11.0 11.73% <ø> (?)
check_version_ur7e-5.22.2 11.78% <ø> (?)
check_version_ur8long-10.12.1 11.78% <ø> (?)
check_version_ur8long-5.25.1 11.73% <ø> (?)
python_scripts 75.90% <ø> (ø)
start_ursim 83.51% <ø> (-1.58%) ⬇️
ur20-latest 72.76% <ø> (-0.40%) ⬇️
ur5-3.14.3 72.53% <ø> (?)
ur5e-10.11.0 66.80% <ø> (-0.52%) ⬇️
ur5e-10.12.0 67.83% <ø> (-0.49%) ⬇️
ur5e-10.7.0 66.34% <ø> (-0.32%) ⬇️
ur5e-5.9.4 73.35% <ø> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@urfeex urfeex mentioned this pull request May 19, 2026
@urfeex urfeex merged commit de90b90 into UniversalRobots:master May 19, 2026
57 of 63 checks passed
@urfeex urfeex deleted the fix_cb3_example branch May 19, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants