Make circular motion in example more compatible#508
Merged
Conversation
This motion should work on - UR5 - UR5e - UR20 These are all the models we currently use during tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #508 +/- ##
==========================================
+ Coverage 76.96% 77.31% +0.35%
==========================================
Files 116 116
Lines 6343 6353 +10
Branches 2761 2764 +3
==========================================
+ Hits 4882 4912 +30
+ Misses 1113 1087 -26
- Partials 348 354 +6 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
urrsk
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This motion should work on
These are all the models we currently use during tests.
Another approach would be to use relative target positions, but I would like to leave that for a later iteration.
Note
Low Risk
Low risk: changes are limited to an example program’s hardcoded motion waypoints and should not affect library behavior. Main risk is the updated demo trajectory still failing or behaving unexpectedly on some robot configurations.
Overview
Adjusts the
examples/instruction_executor.cppmotion demo to make the showcased circular move (moveC) more broadly executable across UR5/UR5e/UR20.Specifically replaces the previous
moveCvia/target waypoints with a precedingmovePand new via/target pose + joint targets intended to be more compatible.Reviewed by Cursor Bugbot for commit ee4bd1a. Bugbot is set up for automated code reviews on this repo. Configure here.