-
Notifications
You must be signed in to change notification settings - Fork 2
port to ROS2 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port to ROS2 #5
Conversation
|
@fmauch: would you be interested in merging this here? It would save us from maintaining an(other) fork and might help others trying to use this in ROS 2 as well. There's no CI currently here, correct? Edit: there is CI, apologies. |
|
Yes, that would be nice to have here. Not necessarily the main branch, though. |
If you can create a new ROS2-dedicated branch to which I can target this PR that would be great. Thanks |
fmauch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good at least for an initial version. I'll create a ROS 2 branch, merge this PR manually, update CI for ROS 2 and push that to Github. Thanks @SyZbidi
|
I'll take some time to do that anyway, since I'll have to squeeze that in between childcare. I wouldn't push things before I've tested them manually, anyway. |
|
We have them locally. Just finishing lunch :) |
|
@fmauch Done with the final changes, happy to contribute :) |
|
@SyZbidi could you rebase on |
fix ROS2 message type Make geometry_msgs findable by CMake update dependencies
Done |
|
Thank you @SyZbidi! |
Ported package to ROS2