Skip to content

Conversation

@SyZbidi
Copy link

@SyZbidi SyZbidi commented Mar 5, 2024

Ported package to ROS2

@gavanderhoorn
Copy link
Contributor

gavanderhoorn commented Mar 5, 2024

@fmauch: would you be interested in merging this here? It would save us from maintaining an(other) fork and might help others trying to use this in ROS 2 as well.

There's no CI currently here, correct?


Edit: there is CI, apologies.

@fmauch
Copy link

fmauch commented Mar 5, 2024

Yes, that would be nice to have here. Not necessarily the main branch, though.

@SyZbidi
Copy link
Author

SyZbidi commented Mar 5, 2024

Yes, that would be nice to have here. Not necessarily the main branch, though.

If you can create a new ROS2-dedicated branch to which I can target this PR that would be great. Thanks

Copy link

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good at least for an initial version. I'll create a ROS 2 branch, merge this PR manually, update CI for ROS 2 and push that to Github. Thanks @SyZbidi

@gavanderhoorn
Copy link
Contributor

There are still one or two changes missing @fmauch. @SyZbidi was going to push those in a bit.

@fmauch
Copy link

fmauch commented Mar 6, 2024

I'll take some time to do that anyway, since I'll have to squeeze that in between childcare. I wouldn't push things before I've tested them manually, anyway.

@gavanderhoorn
Copy link
Contributor

We have them locally. Just finishing lunch :)

@SyZbidi
Copy link
Author

SyZbidi commented Mar 6, 2024

@fmauch Done with the final changes, happy to contribute :)

@fmauch fmauch changed the base branch from main to ros2-main March 6, 2024 12:05
@fmauch
Copy link

fmauch commented Mar 6, 2024

@SyZbidi could you rebase on ros2-main please? that should make the workflows run correctly.

fix ROS2 message type

Make geometry_msgs findable by CMake

update dependencies
@SyZbidi
Copy link
Author

SyZbidi commented Mar 6, 2024

@SyZbidi could you rebase on ros2-main please? that should make the workflows run correctly.

Done

@fmauch fmauch merged commit 29bc545 into UniversalRobots:ros2-main Mar 6, 2024
@fmauch
Copy link

fmauch commented Mar 6, 2024

Thank you @SyZbidi!

@SyZbidi SyZbidi deleted the ros2 branch March 6, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants