Skip to content

feat: get and set project access #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gastonfournier merged 9 commits into from
Oct 13, 2023
Merged

feat: get and set project access #18

gastonfournier merged 9 commits into from
Oct 13, 2023

Conversation

@gastonfournier
Copy link
Collaborator

@gastonfournier gastonfournier commented Oct 10, 2023 •
edited
Loading

About the changes

This introduces "set project access API method". For the review, everything under client can be ignored as that's auto-generated

Also:

  1. Updated .github/workflows/build.yml to use the image in the build config rather than a secret (already aligned with @gardleopard)
  2. Improve documentation for testing and limit tests to the ones that have value.
  3. Updated generate.sh script to get openapi spec from ushosted and also to fail if something goes wrong
  4. On operations.yaml, replaced addAccessToProject with setProjectAccess
  5. Added tests for setProjectAccess and fixed tests due to changes in RoleWithPermission Schema

@gastonfournier gastonfournier self-assigned this Oct 10, 2023
sighphyre
sighphyre approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G

@gastonfournier gastonfournier merged commit 5d7531a into main Oct 13, 2023
@gastonfournier gastonfournier deleted the get-project-access branch October 13, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sighphyre sighphyre sighphyre approved these changes

Assignees

@gastonfournier gastonfournier

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gastonfournier @sighphyre