feat: sso settings #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill make an http call
sighphyre
commented
Sep 3, 2024
| updateUser.RootRole = &rootRole | ||
|
|
||
| resp, httpRes, err := apiClient.UsersAPI.UpdateUser(context.Background(), id).UpdateUserSchema(*updateUser).Execute() | ||
| resp, httpRes, err := apiClient.UsersAPI.UpdateUser(context.Background(), user.Id).UpdateUserSchema(*updateUser).Execute() |
Member
Author
There was a problem hiding this comment.
Caused by a change in upstream types. This becomes a string internally anyway so it won't break against Unleash but does require users of this project to change their types when using the API
sighphyre
commented
Sep 3, 2024
| timeout: 1m | ||
| retries: 5 | ||
| start_period: 10s | ||
| mock-openid-server: |
Member
Author
There was a problem hiding this comment.
Intentional but weird. When striking OIDC endpoints in Unleash, Unleash will make a call to retrieve the well known OIDC config. If it does not find that config, it will fail the call to set OIDC config, but only after it's blocked for a few seconds. It's seriously rude to be striking someone's OIDC config endpoint in tests so this spins up a Python HTTP server which will serve up a valid well known OIDC config for the tests to consume
sighphyre
force-pushed
the
feat/sso-settings
branch
from
90ef4c6 to
faca64f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds simple/OIDC and SAML settings to the generated client.
Also fixes a test that broke in the users API, this isn't a breaking change against Unleash but it is a breaking change for the public API for this project
This needed some changes to the Unleash enterprise OpenAPI schemas but thankfully should work with older versions of Unleash
This is currently failing on 5.8 and below because there's no way to get root roles for older versions of settings