Feat/tag type frontend display #9630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
FredrikOseberg
commented
Mar 31, 2025
| value, | ||
| type, | ||
| }).then(async () => { | ||
| await refetchTags(); |
Contributor
Author
There was a problem hiding this comment.
Uneccesary await, not async function.
kwasniew
reviewed
Mar 31, 2025
|
|
||
| // For non-color tags, use the StyledTag approach | ||
| const isOverflowing = tagFullText.length > 30; | ||
| const displayText = isOverflowing |
Contributor
There was a problem hiding this comment.
maybe a test for the ... logic?
Contributor
Author
There was a problem hiding this comment.
My reasoning here is that it this was the way it worked before, this is just moved to another place, and will be removed when the feature flag is removed.
kwasniew
reviewed
Mar 31, 2025
| sx={{ cursor: 'pointer' }} | ||
| onClick={() => onClick(tag)} | ||
| key={tag} | ||
| onClick={() => onClick(`${tag.type}:${tag.value}`)} |
Contributor
There was a problem hiding this comment.
we keep constructing this type:value in so many places. Maybe we need a first class function for that?
kwasniew
approved these changes
Mar 31, 2025
github-project-automation
bot
moved this from In Progress
to Approved PRs
in Issues and PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize Tag Component and Add Color Support
Changes
tagTypeColorfeature flag to control tag color displayTagcomponent for consistent styling and behaviorITaginterface to OpenAPI-generatedTagSchemaNew tags:
Old: