Remove canoe station from chop menu handling#28
Merged
Conversation
This is a blanket change to remove this plugin from interfacing with canoe stations. It may be preferable to have this behavior be toggled by a plugin configuration option, but to me this seems like the most reasonable default behavior given the latest game update.
Contributor
Author
|
P.S. hope it's alright to propose this change without asking. It just seemed like such a straightforward change after looking at the code that it felt silly to ask someone else to take care of it. Tested this locally and it seems to behave exactly as you'd expect. |
Contributor
|
Correct me if i'm wrong here; we could check the canoe deposited axe and not hard remove the function from the plugin no? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a blanket change to remove this plugin from interfacing with canoe stations.
It may be preferable to have this behavior be toggled by a plugin configuration option, but to me this seems like the most reasonable default behavior given the latest game update.