Skip to content

fix(ui): replace dlgs dialogs with zenity#616

Merged
davidnewhall merged 2 commits intoUnpackerr:mainfrom
SergioChan:fix/replace-dlgs-with-zenity-608
Mar 12, 2026
Merged

fix(ui): replace dlgs dialogs with zenity#616
davidnewhall merged 2 commits intoUnpackerr:mainfrom
SergioChan:fix/replace-dlgs-with-zenity-608

Conversation

@SergioChan
Copy link
Copy Markdown
Contributor

@SergioChan SergioChan commented Mar 12, 2026

Summary

  • replace github.com/gen2brain/dlgs with github.com/ncruces/zenity in the GUI dialog wrapper (pkg/ui/dlgs.go)
  • preserve existing wrapper semantics for callers (bool,error and string,bool,error), including mapping canceled dialogs to ok=false without surfacing an error
  • update dependency guard allowlist to permit github.com/ncruces/zenity
  • Closes dlgs is dead #608.

Validation

  • go test ./pkg/ui
  • go test ./pkg/unpackerr -run TestDoesNotExist
  • GOOS=windows GOARCH=amd64 go test ./pkg/ui
  • git diff --check

Notes

  • GOOS=darwin GOARCH=amd64 go test ./pkg/ui currently fails in this Windows environment due to existing github.com/getlantern/systray darwin build limitations (nativeLoop/registerSystray unresolved). The zenity wrapper changes compile and test on native host + windows cross-compile.

SergioChan and others added 2 commits March 11, 2026 20:41
Addresses Unpackerr#608 by switching GUI dialog wrappers from github.com/gen2brain/dlgs to github.com/ncruces/zenity.
@davidnewhall
Copy link
Copy Markdown
Collaborator

Thanks for this. Saves me a few tokens.

GOOS=darwin GOARCH=amd64 go test ./pkg/ui currently fails in this Windows environment

That's fully expected and why the official build uses macOS and not a cross-compile - it doesn't work. Perhaps I'll find a better systray library to make this better. something like this github.com/energye/systray

@davidnewhall davidnewhall merged commit ec92f44 into Unpackerr:main Mar 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

dlgs is dead

2 participants