Skip to content

Conversation

@awalker4
Copy link
Contributor

@awalker4 awalker4 commented Sep 23, 2024

Making sure this is covered in the docs before we publish 0.26.0 with the new partition_async.

@awalker4 awalker4 marked this pull request as ready for review September 30, 2024 19:14
@awalker4 awalker4 changed the title WIP: New Python SDK Document the new async feature in the Python SDK Sep 30, 2024

<CodeGroup>
```python Python
```python Python (TypedDict example)
Copy link
Collaborator

@Paul-Cornell Paul-Cornell Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like we now have two ways to use the SDK: one pattern is to use the SDK to process a single file synchronously; the other pattern is how to use the SDK to process multiple files asynchronously. If so, then we should probably lead with the the mutli-file async pattern, as this provides the most power and flexibility. We should then follow with the single file sync pattern--perhaps even noting that we don't prefer its use anymore but still available for backward compatibility (that said, there are some breaking changes with this way as well).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(And we should probably update all of the Python SDK examples across the docs to now show how to use the multi-file async pattern only?)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A quick follow-up: we can wait until later to update all of the Python SDK examples across the docs to now show how to use the multi-file async pattern only.)

@awalker4 awalker4 requested a review from Paul-Cornell October 1, 2024 22:06
@awalker4 awalker4 requested a review from Paul-Cornell October 4, 2024 19:52
@awalker4 awalker4 merged commit 027c6db into main Oct 7, 2024
1 check passed
@Paul-Cornell Paul-Cornell deleted the chore/python-sdk-v0.26.0 branch October 7, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants