Skip to content

fix: memory leak on chipper processor, beam search parameters, and bbox bug #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2023
Merged

fix: memory leak on chipper processor, beam search parameters, and bbox bug #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93ecce5
First commit
ajjimeno Oct 17, 2023
f61a37a
Removed print
ajjimeno Oct 17, 2023
ce15f8e
Version bump
ajjimeno Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 0.7.7

• Fix a memory leak in DonutProcessor when using large images in numpy format
• Set the right settings for beam search size > 1
• Fix a bug that in very rare cases made the last element predicted by Chipper to have a bbox = None

## 0.7.6

* fix a bug where invalid zoom factor lead to exceptions; now invalid zoom factors results in no scaling of the image
Expand Down
2 changes: 1 addition & 1 deletion unstructured_inference/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.7.6" # pragma: no cover
__version__ = "0.7.7" # pragma: no cover
11 changes: 4 additions & 7 deletions unstructured_inference/models/chipper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,7 @@ def predict_tokens(
with torch.no_grad():
encoder_outputs = self.model.encoder(
self.processor(
np.array(
image,
np.float32,
),
image,
return_tensors="pt",
).pixel_values.to(self.device),
)
Expand All @@ -177,9 +174,9 @@ def predict_tokens(
encoder_outputs=encoder_outputs,
input_ids=self.input_ids,
logits_processor=self.logits_processor,
do_sample=False,
do_sample=True,
no_repeat_ngram_size=0,
num_beams=5,
num_beams=3,
return_dict_in_generate=True,
output_attentions=True,
output_scores=True,
Expand Down Expand Up @@ -304,7 +301,7 @@ def postprocess(
end = i

# If exited before eos is achieved
if start != -1 and start < end and len(parents) > 0:
if start != -1 and start <= end and len(parents) > 0:
slicing_end = end + 1
string = self.tokenizer.decode(output_ids[start:slicing_end])

Expand Down