Skip to content

Conversation

@badGarnet
Copy link
Collaborator

@badGarnet badGarnet commented Nov 6, 2023

This PR addresses CORE-2485

  • now table's html representation is in text_as_html attribute
  • the attribute text now only contains text without any html tags
  • add a new utils to strip tags from html strings

- now table's html representation is in `text_as_html` attribute
- the attribute `text` now only contains text without any html tags
- add a new utils to strip tags from html strings
@badGarnet badGarnet marked this pull request as ready for review November 6, 2023 17:24
@badGarnet badGarnet requested review from benjats07 and qued November 6, 2023 17:24
CHANGELOG.md Outdated
@@ -1,8 +1,9 @@
## 0.7.11-dev2
## 0.7.11-dev3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 0.7.11-dev3
## 0.7.11

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you meant to cut a release with this merge?

Copy link
Contributor

@benjats07 benjats07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badGarnet badGarnet enabled auto-merge (squash) November 6, 2023 17:54
@badGarnet badGarnet merged commit e602972 into main Nov 6, 2023
@badGarnet badGarnet deleted the fix/chipper-table-element-same-as-others branch November 6, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants