Skip to content

Conversation

@Coniferish
Copy link
Contributor

This PR adds a test that checks if the retry logic is operating using custom retry configurations (for the sake of time when running the test). This test also requires that an UNS_API_KEY be set in your local environment. This can be done by exporting it in your bash session (export UNS_API_KEY=<api_key>).

Additionally, it adds a .genignore file, which is used to tell Speakeasy to ignore this test file so it is not overwritten.

@Coniferish Coniferish requested a review from awalker4 December 5, 2023 17:39
@awalker4
Copy link
Collaborator

awalker4 commented Dec 5, 2023

Awesome! Can you add a makefile for make test? I didn't have requests-mock locally. I wonder if we should just install it in the make target rather than deal with a requirements file right now.

@Coniferish
Copy link
Contributor Author

@awalker4 sounds good to me! I'll add the install in the make target

@Coniferish
Copy link
Contributor Author

@awalker4, added the makefile. Lmk if you think it looks okay.

Copy link
Collaborator

@awalker4 awalker4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@awalker4 awalker4 merged commit de486af into main Dec 13, 2023
@Coniferish Coniferish deleted the jj/create-test branch December 13, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants