add jupyter notebook and decorator to change server_url #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coniferish
force-pushed
the
jj/decorators
branch
2 times, most recently
from
c76c8c9 to
bcfea6c
Compare
Coniferish
changed the title
Coniferish
force-pushed
the
jj/decorators
branch
2 times, most recently
from
5e77630 to
68a834e
Compare
Coniferish
changed the title
Coniferish
changed the title
Coniferish
force-pushed
the
jj/decorators
branch
from
68a834e to
ee8e882
Compare
awalker4
reviewed
Feb 5, 2024
awalker4
approved these changes
Feb 5, 2024
awalker4
reviewed
Feb 5, 2024
Coniferish
force-pushed
the
jj/decorators
branch
from
ee8e882 to
7f9cfa0
Compare
Coniferish
force-pushed
the
jj/decorators
branch
from
7f9cfa0 to
efb3aad
Compare
awalker4
approved these changes
Feb 5, 2024
Coniferish
force-pushed
the
jj/decorators
branch
from
efb3aad to
d3f618a
Compare
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial solution to #30
This PR creates new
makecommands, includingmake run-jupyterfor starting a local notebook. The notebook that's created runs the example code from the README (this is manually copied from the README, so this may become outdated in time). The README assumes you are actually in theunstructured-apidirectory, but the file referenced in the notebook is in a newly created directory for this repo.This PR also starts using an underscore before directories that are human-written and adds those directories to the .genignore file.
NOTE: this PR sets up a pattern of managing dependencies through the MAKEFILE. Since setup.py isn't a document that we can reliably edit since it is auto-generated, requirements are added to the MAKEFILE and users should run
make installto install packages needed for local development (such as jupyter).This PR also creates a decorator for modifying the
server_urlthat users pass to UnstructuredClient. This decorator removes the/general/v0/generalpath that is sometimes incorrectly added and fixes the http/https scheme.