build(deps): dependency cleanup#1102
Merged
Merged
Conversation
cragwolfe
approved these changes
Aug 12, 2023
Contributor
cragwolfe
left a comment
cragwolfe
left a comment
There was a problem hiding this comment.
LGTM.
let's make this a release commit since it is about time anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to clean up some pins that were prone to conflicts.
cryptographywas the main offender, and could have been cleaned up by moving the pin toconstraints.in, but with this PR I'm floating the idea that the undocumented pins aren't necessary.So if you have pinned something that's unpinned here for reasons other than to resolve a dependency conflict, please chime in, and let's get it pinned in the right place with a note.
Testing:
CI should pass, and no objections about the unpinning.