Skip to content

rfctr(odt): organize and improve test_odt.py#3031

Merged
scanny merged 2 commits intomainfrom
scanny/improve-test-odt
May 16, 2024
Merged

rfctr(odt): organize and improve test_odt.py#3031
scanny merged 2 commits intomainfrom
scanny/improve-test-odt

Conversation

@scanny
Copy link
Contributor

@scanny scanny commented May 15, 2024

Summary
In preparation for adding more tests related to image extraction, improve the partition_odt() test suite:

  • Add type annotations to type-check clean on strict mode.
  • Improve test names.
  • Simplify tests where possible.
  • Remove a couple duplicated tests

Copy link
Contributor

@Coniferish Coniferish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

scanny added 2 commits May 15, 2024 17:08
Line block moves only. No code changes other than new test added at top.
In preparation for adding more tests related to image extraction,
improve the `partition_odt()` test suite:

- Add type annotations to type-check clean on strict mode.
- Improve test names.
- Simplify tests where possible.
- Remove a couple duplicated tests.
@scanny scanny force-pushed the scanny/improve-test-odt branch from bc8bbd7 to cc06d0c Compare May 16, 2024 00:08
@scanny scanny added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit aeca8be May 16, 2024
@scanny scanny deleted the scanny/improve-test-odt branch May 16, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants