Merged
Conversation
rbiseck3
force-pushed
the
roman/fix-ingest-async-connectors
branch
from
25e8082 to
bba303b
Compare
rbiseck3
force-pushed
the
roman/fix-ingest-async-connectors
branch
from
b20032a to
3a87282
Compare
| raise SourceConnectionNetworkError( | ||
| f"failed to download file {file_data.identifier}" | ||
| ) | ||
| async for result in async_scan( |
Contributor
There was a problem hiding this comment.
We now get
Unclosed connector
connections: ['[(<aiohttp.client_proto.ResponseHandler object at 0x13658ee60>, 271841.176414041)...
in the logging. Not sure if we can address this. You would think it would close out the connector when it is done automatically?
Contributor
Author
There was a problem hiding this comment.
I'll look into this
Contributor
Author
There was a problem hiding this comment.
resolved in latest commits
rbiseck3
force-pushed
the
roman/fix-ingest-async-connectors
branch
from
23e64de to
c822b7c
Compare
…ntiate a client anymore
This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rbiseck3 <rbiseck3@users.noreply.github.com>
rbiseck3
force-pushed
the
roman/fix-ingest-async-connectors
branch
from
c822b7c to
7260110
Compare
Contributor
There was a problem hiding this comment.
Is there a good reason that these expected-structured-output files for chunking have changed so much?
Contributor
There was a problem hiding this comment.
Nevermind.! The parameters were not being passed through I assume:)
potter-potter
approved these changes
Jun 17, 2024
Contributor
potter-potter
left a comment
potter-potter
left a comment
There was a problem hiding this comment.
looks good.
Will be interesting to see if it passes this new (2 months old) expected-text-output test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Choosing to use async needs to be very careful because if a connector is set to use async, the pipeline will not fan out the inputs via multiprocessing but instead it will be limited to run in a single process under the assumption it has more benefit from async due to heavy network traffic. This means the exact same code that is not optimized for async and is blocking will force the pipeline to perform worse than simply never marking the connector to use async since the pipeline will fan that out using multiprocessing.
All connectors and processes in the pipeline we revisited to make sure this criteria was met and updated accordingly:
@propertyfetched on demand, otherwise the client would break the multiprocessing pool since it maintains a thread lock and that can't be pickled when the fsspec connector doesn't support async.