Skip to content

feat: change english_words to set for performance gain #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cragwolfe merged 2 commits into from
Mar 19, 2023
Merged

feat: change english_words to set for performance gain #380

cragwolfe merged 2 commits into from
Mar 19, 2023

Conversation

@cragwolfe
Copy link
Contributor

@cragwolfe cragwolfe commented Mar 19, 2023

Before:

(sec) MacBook-Pro-2:unstructured cragwolfe$ time python -c "from unstructured.partition.text import partition_text; partition_text('./unstructured/nlp/english-words.txt')"

real    16m14.820s
user    15m51.560s
sys     0m9.885s

After:

(sec) MacBook-Pro-2:unstructured cragwolfe$ time python -c "from unstructured.partition.text import partition_text; partition_text('./unstructured/nlp/english-words.txt')"

real    1m41.702s
user    1m40.683s
sys     0m2.806s

@cragwolfe cragwolfe enabled auto-merge (squash) March 19, 2023 19:16
@awalker4
Copy link
Contributor

awalker4 commented Mar 19, 2023

Awesome!

@awalker4 awalker4 self-requested a review March 19, 2023 22:11
@cragwolfe cragwolfe mentioned this pull request Mar 19, 2023
Merged
@cragwolfe cragwolfe merged commit fbc7a69 into main Mar 19, 2023
@cragwolfe cragwolfe deleted the crag/english-words-set branch March 19, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awalker4 awalker4 awalker4 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cragwolfe @awalker4