feat: Add stage_for_weaviate and schema creation function
#672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unstructured into feat/stage-for-weaviate
qued
approved these changes
Jun 1, 2023
Contributor
qued
left a comment
qued
left a comment
There was a problem hiding this comment.
For some reason the logic isn't properly skipping the weaviate test in the container.
Side-note: base.txt is out of sync with base.in, maybe through a merge, but it is allowing tests to pass when base.in does not actually require tabulate which is required for some of the table extraction functions. Users will get errors when pip installing and trying to use this functionality. I'll create a PR to address this.
Otherwise, a few doc typos I've highlighted, and assuming the docker issue gets fixed, LGTM!
qued
reviewed
Jun 1, 2023
Contributor
Author
|
Good catch on the base dependencies! |
ryannikolaidis
pushed a commit
that referenced
this pull request
Jun 2, 2023
* add weaviate docker compose * added staging brick and tests for weaviate * initial notebook and requirements file * add commentary to weaviate notebook * weaviate readme * update docs * version and change log * install weaviate client * install weaviate; skip for docker * linting, linting, linting * install weaviate client with deps * comments on weaviate client * fix module not found error for docker container * skipped wrong test in docker * fix typos * add in local-inference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #566. Adds a
stage_for_weaviatefunction to prepare outputs for upload to Weaviate and acreate_unstructured_weaviate_classhelper function for defining the schema.Testing
Run the example Jupyter notebook to test the Weaviate workflow locally.