feat: add ability to extract extra metadata with regex#763
Merged
Conversation
qued
approved these changes
Jun 15, 2023
Contributor
qued
left a comment
There was a problem hiding this comment.
LGTM, a few nits and one question/suggestion. The schema we get back for regex_metadata feels cumbersome (list of dicts for every regex pattern) but I understand why it's that way and can't really think of something better right now.
…nstructured into feat/optional-metadata
Contributor
|
Neat functionality, but isn't this something someone might want to do post |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to extract additional metadata by specifying a regex. Also introduces a
process_metadatadecorator which will allow us to make introduce metadata changes that apply to all document types without having to edit each individual file in thepartitiondirectory.Testing