feat: Add include_metadata across all partition functions #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add exclude_metadata to docx add test for doc to exclude metadata add include_metadata kwarg to email add include_metadata kwarg to epub add include_metadata kwarg to json add exclude_metadata tests to md add include_metadata kwarg and tests for msg parse add include_metadata kwarg and tests for odt parse add include_metadata kwarg and tests for org parse add include_metadata kwarg and tests for ppt and pptx parse add include_metadata kwarg and tests for rst parse add include_metadata kwarg and tests for rtf parse add include_metadata tests for text parse add include_metadata tests for tsv parse add include_metadata tests for xlsx parse add include_metadata tests for xml parse
Coniferish
requested review from
MthwRobinson
and removed request for
MthwRobinson
MthwRobinson
suggested changes
Jun 29, 2023
Contributor
MthwRobinson
left a comment
MthwRobinson
left a comment
There was a problem hiding this comment.
One minor request on where the doc strings are getting added, otherwise looks good
MthwRobinson
approved these changes
Jun 29, 2023
Contributor
MthwRobinson
left a comment
MthwRobinson
left a comment
There was a problem hiding this comment.
LGTM once linting is passing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #820
Adds
include_metadatakwarg to all partition functions except forpartition_image.Adds associated tests for excluding metadata for all partitions.
Adds functionality to
add_metadata_with_filetypedecorator soinclude_metadatainfo is automatically added to a decorated function's docstringTesting