-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix/521 pdf2image memory error #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a time for `ocr_only` strategy
…ing the file in `convert_to_bytes`
# Conflicts: # CHANGELOG.md # unstructured/__version__.py
…e` library using Python generator, apply it to `_partition_pdf_or_image_with_ocr`
qued
approved these changes
Jul 14, 2023
Contributor
qued
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I like the generator implementation! One formatting tweak, and a general (nonblocking) suggestion for the function interface.
qued
reviewed
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes issue #521. Implements the same logic as unstructured-inference/PR #136 for the
ocr_onlystrategy.convert_pdf_to_imagesforpdf2imagelibrary using Python generator, apply it to_partition_pdf_or_image_with_ocrconvert_to_bytesTesting