-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Update CI test paths to enable merge queue validation #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ncrmro
wants to merge
9
commits into
main
Choose a base branch
from
test-pr-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables testing merge queue functionality without affecting main branch. Workflows modified: - validate.yml - claude-code-test.yml - cla.yml Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Changes: - Fix claude-code-test.yml paths from .claude/commands/ to .claude/skills/ (generator now outputs to skills/ directory) - Remove test-merge-queue branch references from workflow triggers - Remove temporary test files This fix enables the merge queue to properly validate PRs before merging. The CI tests were previously passing on PRs because they skip actual tests, but would fail in the merge queue due to incorrect paths. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The test workflow expected flat skill files but the generator creates skill directories. Updated all path checks from `.claude/skills/X.md` to `.claude/skills/X/SKILL.md` format. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The --yes flag doesn't exist in the Claude CLI. The correct flag for bypassing permission prompts in CI is --dangerously-skip-permissions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
* test: Add test-merge-queue branch to workflow triggers This enables testing merge queue functionality without affecting main branch. Workflows modified: - validate.yml - claude-code-test.yml - cla.yml Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test: Second test PR for merge queue validation * test: First test PR for merge queue validation (#172) * fix: Update CI test paths and enable merge queue validation Changes: - Fix claude-code-test.yml paths from .claude/commands/ to .claude/skills/ (generator now outputs to skills/ directory) - Remove test-merge-queue branch references from workflow triggers - Remove temporary test files This fix enables the merge queue to properly validate PRs before merging. The CI tests were previously passing on PRs because they skip actual tests, but would fail in the merge queue due to incorrect paths. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: Update CI test paths for skill directory structure The test workflow expected flat skill files but the generator creates skill directories. Updated all path checks from `.claude/skills/X.md` to `.claude/skills/X/SKILL.md` format. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: Use --dangerously-skip-permissions instead of --yes for Claude CLI The --yes flag doesn't exist in the Claude CLI. The correct flag for bypassing permission prompts in CI is --dangerously-skip-permissions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
claude-code-test.ymlpaths from.claude/commands/to.claude/skills/Problem
The CI tests in
claude-code-test.ymlwere looking for generated skills in.claude/commands/but the generator now outputs to.claude/skills/. This caused:pull_requestevent)merge_groupevent)This meant PRs could never successfully merge through the merge queue.
Solution
Update all path references in
claude-code-test.ymlfrom.claude/commands/to.claude/skills/to match the current generator output.Test plan
merge_groupevent triggers full tests🤖 Generated with Claude Code