Conversation
Trombach
reviewed
Feb 22, 2022
...ub-web/src/app/components/search-page/search-results-list/search-results-list.component.html
Outdated
Show resolved
Hide resolved
…-list/search-results-list.component.html Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com>
Merged
rosemcc
added a commit
that referenced
this pull request
Feb 24, 2022
* delete unused components * show external links icons * tweaks to card titles for consistency * navigateTo changed to window.open, fix typo * minor fixes * close search autocomplete panel on enter keypress * readme * chore: version bump * Bump nodemon from 2.0.12 to 2.0.15 in /cer-graphql Bumps [nodemon](https://github.com/remy/nodemon) from 2.0.12 to 2.0.15. - [Release notes](https://github.com/remy/nodemon/releases) - [Commits](remy/nodemon@v2.0.12...v2.0.15) --- updated-dependencies: - dependency-name: nodemon dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * external links icon not on phone numbers * fix link card external icon * cards external links functionality and accessibility * fix tabbing on contact card * open assets in new tab * dont show external link icon on home page banner content * chore: add subhub-link-checker to dependabot.yml * Bump contentful-export from 7.13.34 to 7.14.11 in /hub-search-proxy Bumps [contentful-export](https://github.com/contentful/contentful-export) from 7.13.34 to 7.14.11. - [Release notes](https://github.com/contentful/contentful-export/releases) - [Commits](contentful/contentful-export@v7.13.34...v7.14.11) --- updated-dependencies: - dependency-name: contentful-export dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * npm update, lock @elastic/elasticsearch version to 7.13.0 due to breaking change in v7.14+ * Bump nodemon from 2.0.12 to 2.0.15 in /cer-graphql Bumps [nodemon](https://github.com/remy/nodemon) from 2.0.12 to 2.0.15. - [Release notes](https://github.com/remy/nodemon/releases) - [Commits](remy/nodemon@v2.0.12...v2.0.15) --- updated-dependencies: - dependency-name: nodemon dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * updated dev dependencies * more updates * Persistent Notification (#202) * added animation to notification * 1st version remember persistant notification * refactored notification request into service * formatting * code cleanup and comments * minor fix to method description * more changes to comments * unit tests for getNotification() function * removed some unused code from unit test * added test for storeCurrentNotificationVersion * improved close function * removed focused describe Co-authored-by: Rose <31844476+rosemcc@users.noreply.github.com> * added filter counter to tab labels (#208) * remove unused dependencies and use lockfile version 2 (#207) * remove unused dependencies and use lockfile version 2 * update sentry to latest * update rxjs, npm audit fix * fix interface change to iif() in rxjs 7 * fix chunkload error Co-authored-by: rosemcc <rosemccoll@hotmail.com> * chore: add PR templates * chore: generic PR template * chore: delete separate PR templates * Angular-13.1 (#211) * update ng-mocks * update @angular/cli * update @angular/material @angular/core * npm update * removed workaround for mat-card-image on picture tags * added missing mat-card-image directive * fixed default images not rendered properly, minor re-factor * minor tidy up * update karma version * Service worker (#210) * ng add @angular/pwa * set theme-color * replace default Angular icons with UoA * clean up codeCoverageExclude * readme * Material icons and fonts caching * Revert "Material icons and fonts caching" This reverts commit 14b2e3c. * material icons, uoa fonts, contentful assets caching, readme * lazy fetch contentful assets * service worker on prod index.html * App name * add script to run in service worker mode locally * csp update WIP * 504 gateway timeout bypass * sw updates service WIP * note * unit tests passing * more csp updates due to service worker fetching * about link fix on footer * adding sw-updates functionality * add nontransparent icon for apple-touch-icon * replace deprecated methods, add error handling * package-lock fix after merge * tidying, add types * material dialog for update confirmation * tests passing * Change dialog to snackbar, add styling * add a test * remove unused material modules * button style * minor update to script and readme for running service worker locally * fix snackbar style * add app id to manifest * refactor swUpdates, add tests * remove f * add maskable icons * icons fix * add apple touch icon * changes to pipe and unit test * remove unused imports Co-authored-by: Luke <lukas.trombach@auckland.ac.nz> * Bump contentful-export from 7.14.11 to 7.14.27 in /hub-search-proxy Bumps [contentful-export](https://github.com/contentful/contentful-export) from 7.14.11 to 7.14.27. - [Release notes](https://github.com/contentful/contentful-export/releases) - [Commits](contentful/contentful-export@v7.14.11...v7.14.27) --- updated-dependencies: - dependency-name: contentful-export dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump @graphql-codegen/typescript in /research-hub-web Bumps [@graphql-codegen/typescript](https://github.com/dotansimha/graphql-code-generator/tree/HEAD/packages/plugins/typescript/typescript) from 1.23.0 to 2.4.3. - [Release notes](https://github.com/dotansimha/graphql-code-generator/releases) - [Changelog](https://github.com/dotansimha/graphql-code-generator/blob/master/packages/plugins/typescript/typescript/CHANGELOG.md) - [Commits](https://github.com/dotansimha/graphql-code-generator/commits/@graphql-codegen/typescript@2.4.3/packages/plugins/typescript/typescript) --- updated-dependencies: - dependency-name: "@graphql-codegen/typescript" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update for Terraform AWS Provider v4.0.0 (#225) * s3 bucket config updates for provider v4 * add missing indices on secondary website bucket configs * add version constraint for AWS provider * Dependency cleanup (#229) * remove nodemon and webdriver manager, remove unneeded script * remove apollo-link * remove aws4 and aws-sdk * Merge branch 'master' into dependency-cleanup * more unused deps * update jasmine-core, npm audit fix * package updates, fix ngx-markdown breaking change * package-lock * update sentry, date-fns * update @angular/core to 13.2.3 * update @angular-eslint/schematics to 13.1.0 * added graphql devDependency for codegen Co-authored-by: Lukas Trombach <lukas.trombach@auckland.ac.nz> * Update subhub link checker deps (#226) * Update versions * Update f36 deps * Update to use new methods * Rewrite promises as async blocks * Bump @types/react-dom version * Run npm audit fix * Add more instructions for deployment * Add note about official release process * Update package lock file to use v2 - Also remove unused imports * Search Cards Linking Behaviour (#231) * add anchor tag over whole card, fix title styling * Update research-hub-web/src/app/components/search-page/search-results-list/search-results-list.component.html Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com> * fix link * fix link Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com> Co-authored-by: Luke <lukas.trombach@auckland.ac.nz> Co-authored-by: Noel <39939032+uoa-noel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
User feedback was received that users would like search cards to have standard link behaviour so that mouse and keyboard shortcuts to open in new browser tabs or windows is available. Currently the search cards do not contain an anchor element, and only allow navigation through the router, within the same tab.
Solution
Added anchor tag as the first child of search result cards, and positioned the anchor over the whole card. This implementation means that the anchor tag functionality works over the whole card, but it does not interfere with the functionality of the search category chips at the bottom of the card, as these have their own search behaviour. Because the anchor tag covers the whole area of the card, the solution also required a minor modification to the hover styling of the card title as follows:
The PR also contains a minor tidy up of the css for search result card titles.
Screenshots
No visible change to UI
Testing
No new tests required
Have the changes been checked in the following browsers?