Conversation
Comment on lines
24
to
28
| "mkdir -p " + specialFilesParentDir_ + "/specialFiles/"; | ||
| const std::string rm_input = | ||
| "rm -r " + specialFilesParentDir_ + "/specialFiles/*"; | ||
| system(rm_input.c_str()); | ||
| system(mk_input.c_str()); |
Contributor
There was a problem hiding this comment.
Need to swap the two system calls around
jj16791
changed the title
…ation to avoid re-occurring issues with certain environments unpredictably erroring on its inclusion
…on of its contents
FinnWilkinson
approved these changes
Jan 7, 2022
Contributor
FinnWilkinson
left a comment
FinnWilkinson
left a comment
There was a problem hiding this comment.
All looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains some minor bug fixes including:
specialFilesdirectory. It would fail in theRemoveExistingSFDirfunction ofSpecialFileDirGen.ccdue toNo such file or directoryerror.getdents64system call in favour of custom implementation to avoid re-occurring unpredictable issues whereby builds fail due to the system calls inclusion.