Merged
Conversation
… values from a single block of fetched memory in Instruction_execute.
jj16791
approved these changes
Jul 14, 2023
rahahahat
reviewed
Jul 14, 2023
rahahahat
reviewed
Jul 14, 2023
rahahahat
reviewed
Jul 14, 2023
rahahahat
reviewed
Jul 14, 2023
rahahahat
reviewed
Jul 14, 2023
rahahahat
reviewed
Jul 14, 2023
rahahahat
reviewed
Jul 14, 2023
rahahahat
reviewed
Jul 14, 2023
rahahahat
reviewed
Jul 14, 2023
rahahahat
requested changes
Jul 14, 2023
Contributor
rahahahat
left a comment
rahahahat
left a comment
There was a problem hiding this comment.
Looks good! Just a few redundant static_casts
rahahahat
reviewed
Jul 14, 2023
rahahahat
approved these changes
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All single structure, contiguous vector loads (both NEON and SVE) have been adapted to generate a sigle address rather than one per element.
This change is largely motivated by a lack of accuracy to real hardware when simulating with SimEng-SST. Functionally, the instructions have not been altered.