Skip to content

feature/exec grid#69

Merged
joengy merged 10 commits into
mainfrom
feature/photo-grid
May 13, 2026
Merged

feature/exec grid#69
joengy merged 10 commits into
mainfrom
feature/photo-grid

Conversation

@Richman-Tan
Copy link
Copy Markdown
Contributor

@Richman-Tan Richman-Tan commented May 12, 2026

This pull request introduces a new "Meet the SSA Team" section to the About page, displaying the executive members in a responsive grid layout. It adds the necessary components and data structure to render executive cards with names, roles, and placeholder photos, and updates the About page to include this new section.

New "Meet the SSA Team" section:

  • Added the ExecCard component to display individual executive member information with interactive hover/tap overlay effects, including accessibility features for keyboard navigation.
  • Added the ExecGrid component to render a responsive grid of all executive members using the ExecCard component.
  • Created the execData.ts module defining the ExecMember type and a hardcoded list of executive members with placeholder photos (to be replaced by real data in the future).

Integration into About page:

  • Updated page.tsx to import and render the new ExecGrid component, replacing the previous placeholder content. [1] [2]

#49

Copilot AI review requested due to automatic review settings May 12, 2026 10:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new “Meet the SSA Team” section to the About page by introducing reusable About-specific components for rendering executive member cards in a responsive grid, backed by a static data module.

Changes:

  • Updated the About page to render a new ExecGrid section instead of placeholder content.
  • Added ExecGrid to lay out exec members responsively and render an ExecCard per member.
  • Added execData.ts to define the ExecMember type and a hardcoded list of members/photos.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
web/src/app/about/page.tsx Wires the new exec grid section into the About page.
web/src/app/about/_components/ExecGrid.tsx Introduces the responsive grid layout for exec cards.
web/src/app/about/_components/ExecCard.tsx Adds the interactive, image-based exec card (hover/tap overlay).
web/src/app/about/_components/execData.ts Provides the exec member data model and hardcoded member list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread web/src/app/about/_components/ExecGrid.tsx Outdated
Comment thread web/src/app/about/_components/ExecCard.tsx Outdated
Comment thread web/src/app/about/_components/ExecCard.tsx Outdated
Comment thread web/src/app/about/_components/execData.ts Outdated
Copy link
Copy Markdown
Collaborator

@oorjagandhi oorjagandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good! Just two small comments

Also can u link ur ticket in the PR description

year: string
}

export const execMembers: ExecMember[] = [
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u change all 2024 -> 2026

/>
<div
aria-hidden="true"
className={`absolute inset-0 bg-black/60 flex flex-col justify-end pb-6 pl-5 pr-3 pt-3 sm:pb-8 sm:pl-6 transition-opacity duration-300 ${
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please up the duration to 500 instead of 300 so its a bit more gradual

…ecData years for team members

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings May 12, 2026 11:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

Comment thread web/src/app/about/_components/ExecGrid.tsx
Comment thread web/src/app/about/_components/ExecGrid.tsx Outdated
Comment thread web/src/app/about/_components/ExecCard.tsx Outdated
Comment thread web/src/app/about/_components/execData.ts
Comment thread web/src/app/about/_components/ExecCard.tsx Outdated
@Richman-Tan Richman-Tan changed the title feat: add ExecCard and ExecGrid components to display team members feature/exec grid May 12, 2026
… removing year property

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings May 12, 2026 13:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comment thread web/src/app/about/_components/execData.ts
Comment thread web/src/app/about/_components/ExecCard.tsx Outdated
Comment thread web/src/app/about/_components/ExecGrid.tsx
Copilot AI review requested due to automatic review settings May 13, 2026 04:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

<div
aria-hidden="true"
className={`absolute inset-0 bg-black/60 flex flex-col justify-end pb-6 pl-5 pr-3 pt-3 sm:pb-8 sm:pl-6 transition-opacity duration-500 ${
isActive ? 'opacity-100' : 'opacity-0 group-hover:opacity-100'
Copy link
Copy Markdown
Collaborator

@oorjagandhi oorjagandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Nice work :D

Copy link
Copy Markdown
Collaborator

@joengy joengy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grid looks great Richman, and the code is clean. Good job !!!

@joengy joengy merged commit 5136f27 into main May 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants