Skip to content

chore: remove tracked web/package-lock.json#88

Merged
joengy merged 1 commit into
mainfrom
chore/remove-stray-package-lock
May 24, 2026
Merged

chore: remove tracked web/package-lock.json#88
joengy merged 1 commit into
mainfrom
chore/remove-stray-package-lock

Conversation

@joengy
Copy link
Copy Markdown
Collaborator

@joengy joengy commented May 23, 2026

Summary

  • Deletes web/package-lock.json from tracking. This repo is a pnpm workspace (pnpm-lock.yaml + pnpm-workspace.yaml), and the root .gitignore already lists package-lock.json — but the file was committed before that ignore rule was added, so git kept tracking it.
  • Without this cleanup, a stray npm install can silently bloat the file (this is what happened in Feature/home carousel #83, where ~120 lines of @next/swc-* entries got added).
  • Once this lands, the existing gitignore rule actually takes effect and npm install mistakes won't pollute the diff anymore.

Test plan

  • CI green (Web + Validate branch name jobs)
  • pnpm install at repo root still works cleanly on a fresh checkout

This repo is a pnpm workspace (`pnpm-lock.yaml` + `pnpm-workspace.yaml`)
and the root `.gitignore` already lists `package-lock.json`, but the
file was committed before that rule was added so git kept tracking it.
That made it easy for a stray `npm install` to bloat the file.

Removing it from tracking so the existing gitignore rule can do its job.
Copy link
Copy Markdown
Contributor

@deb-coder-man deb-coder-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@joengy joengy merged commit 8869695 into main May 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants