feat(kubernetes): --disable-utility-network-access to nodegroup#236
Merged
villevsv-upcloud merged 5 commits intomainfrom Jul 14, 2023
Merged
Conversation
villevsv-upcloud
force-pushed
the
feat/kubernetes-node-group-utility-network
branch
from
21e6086 to
aab81fb
Compare
kangasta
reviewed
Jul 14, 2023
| fs.StringArrayVar(&p.SSHKeys, "ssh-key", []string{}, "SSH keys to be configured as authorized keys to the nodes.") | ||
| fs.StringVar(&p.Storage, "storage", "", "Storage template to use when creating the nodes. Defaults to `UpCloud K8s` public template.") | ||
| fs.StringArrayVar(&p.Taints, "taint", []string{}, "Taints to be configured to the nodes in `key=value:effect` format") | ||
| config.AddEnableOrDisableFlag(fs, &p.UtilityNetworkAccess, true, "utility-network-access", "utility network access. Enabled by default") |
Member
There was a problem hiding this comment.
Help text could be a bit more descriptive, e.g. utility network access. Enabled by default → Connect worker nodes to the utility network. Enabled by default. would be more similar to k8s create commands --private-node-groups
Member
There was a problem hiding this comment.
Or If set to false, nodes in this group will not have access to utility network. from the TF provider would also be good 👌
Contributor
Author
There was a problem hiding this comment.
Thanks! Using now the TF provider comment style.
kangasta
approved these changes
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.